Hi Alan, Thanks for the review.
On Sat, Aug 28, 2010 at 01:36, Alan Bateman <[email protected]> wrote: > Martin Buchholz wrote: > >> >> The fix looks fine. It might be good to indent the second and third lines > of the test summary Done. > to make it easier to distinguish the test tags from the text. On Windows I > assume the "env" command will run the Cygwin or MKS "env" program rather > than the built-in "env" command. I changed this to use the most portable process invocation, namely <java.home>/bin/java -version IOException is no longer acceptable; removed the catch. It probably matter as the test doesn't actually need the child process to do > anything. > > Right. But let's keep our standards as high as possible. In the same spirit, I tightened the FilePermission from read,write,execute => execute Committing. Martin -Alan. > >
