On 6 October 2010 21:56, Dr Andrew John Hughes <gnu_and...@member.fsf.org> wrote: > On 6 October 2010 21:37, Alan Bateman <alan.bate...@oracle.com> wrote: >> >> This batch eliminates a bunch of compiler warnings from the native code: >> http://cr.openjdk.java.net/~alanb/6989466/webrev/ >> >> It also fixes an incorrect usage of memset found along the way. >> >> -Alan. >> > > This looks good from reading the patch. I'll give it a test build. > -- > Andrew :-) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and the OpenJDK > http://www.gnu.org/software/classpath > http://openjdk.java.net > > PGP Key: 94EFD9D8 (http://subkeys.pgp.net) > Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 >
It builds and there seem to be notably less warnings. The first I see now is: ../../../src/solaris/bin/java_md.c: In function 'LocateJRE': ../../../src/solaris/bin/java_md.c:871:19: warning: cast from pointer to integer of different size ../../../src/solaris/bin/java_md.c: In function 'ContinueInNewThread0': ../../../src/solaris/bin/java_md.c:1084:14: warning: cast from pointer to integer of different size and then some in the net code. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8