Hi Remi (and team), I made changes to SyncFactory and one other class for a similar error. Also cleaned up a couple of other minor issues in these classes.
The webrev can be found at http://cr.openjdk.java.net/~lancea/6982530/ Thank you for catching the error. Regards Lance On Sep 5, 2010, at 10:55 AM, Rémi Forax wrote: > Le 04/09/2010 19:59, lance.ander...@oracle.com a écrit : >> Changeset: d44696691445 >> Author: lancea >> Date: 2010-09-04 13:56 -0400 >> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d44696691445 >> >> 6843995: RowSet 1.1 updates >> Reviewed-by: darcy, valeriep >> >> + src/share/classes/com/sun/rowset/RowSetFactoryImpl.java >> ! src/share/classes/javax/sql/rowset/CachedRowSet.java >> + src/share/classes/javax/sql/rowset/RowSetFactory.java >> + src/share/classes/javax/sql/rowset/RowSetProvider.java >> ! src/share/classes/javax/sql/rowset/package.html >> ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java >> ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java >> > > There is a bug in SyncFactory, it uses the double checked locking pattern, > which is broken in Java :) > > Rémi Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Oracle is committed to developing practices and products that help protect the environment
