Looks good to me. -kto
On Mar 7, 2011, at 11:39 AM, Rama Pulavarthi wrote: > Thanks for the review. We had to make additional changes to run the > tests. Hopefully this is the final webrev for this issue. > > Please review this new webrev which also has changes to > jdk/test/Makefile to run the tests. > http://cr.openjdk.java.net/~ramap/CR7020513-open-webrev/ > > thanks, > Rama Pulavarthi > > On 02/25/2011 12:21 PM, Sean Mullan wrote: >> Looks good to me. >> >> --Sean >> >> On 2/25/11 1:12 PM, Rama Pulavarthi wrote: >>> Please review this updated webrev that has the patch for JDK 7 repo. >>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxws-7020513-open/webrev/ >>> >>> >>> For background on this issue, this is not a new one. I am trying to port >>> the old fixes made in jdk repo as part of earlier jax-ws integrations in >>> to Open JDK 6. >>> The original issue CR 6592792 was fixed in JDK 6u7 and then ported to >>> Open JDK 6. When Open JDK 6 transitioned to Hg, it was committed as >>> [1]. As fix for CR 6831313 >>> <http://monaco.sfbay.sun.com/detail.jsf?cr=6831313>:update jaxws in >>> OpenJDK7 to 2.1 plus bug fixes from OpenJDK 6, Only the changes in jaxws >>> sources are ported to JDK 7 [2]. But, there are other changes that are >>> made in jdk repo required for this fix. >>> >>> [1] http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/586feec8273d >>> <http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/586feec8273d.> >>> [2] http://hg.openjdk.java.net/jdk7/build/jaxws/rev/31822b475baa >>> <http://hg.openjdk.java.net/jdk7/build/jaxws/rev/31822b475baa.> >>> >>> >>> thanks, >>> Rama Pulavarthi >
