Dmytro Sheyko said the following on 04/07/11 17:50:
Just wonder what is the purpose of dummy parameter in native fillInStackTrace 
method. Couldn't we simply rename it (e.g. to fillInStackTrace0)

Using an overload instead of renaming the native method was initially done to avoid having to make changes to the stacktrace filtering code in the VM. It turns out that we need to make a change anyway, but it is easier if we stick with the one name for the method to be filtered out.

This isn't set in concrete though.

David

Date: Wed, 6 Apr 2011 23:29:02 -0700
From: [email protected]
To: [email protected]
Subject: Code review request for 6998871 "Support making the       
Throwable.stackTrace field immutable"

Hello.

Returning to some earlier work, I've developed a proposed fix for

    6998871 "Support making the Throwable.stackTrace field immutable"
    http://cr.openjdk.java.net/~darcy/6998871.2/

One constructor of Throwable now takes an additional boolean argument to make the stack trace information immutable. Analogous constructors are added to Exception, RuntimeException, and Error.

Mandy and David have already reviewed the change; I'm interested in getting additional feedback on the design of the API.

Cheers,

-Joe

Reply via email to