Approved!. I agree with Alan if a change is to be made in a component, it is best that it is pushed to that component's forest/repo, where all the necessary/appropriate tests will be performed on a nightly basis.
Kumar ----- alan.bate...@oracle.com wrote: > From: alan.bate...@oracle.com > To: david.hol...@oracle.com > Cc: awt-...@openjdk.java.net, core-libs-dev@openjdk.java.net > Sent: Saturday, April 9, 2011 1:59:17 AM GMT -08:00 US/Canada Pacific > Subject: Re: Urgent Request for review: 7035109 Regression: awt > SplashScreen/test18.sh fails - missing mapfile entry > > David Holmes wrote: > > Very simple review - the mapfile was missing an entry for a new > native > > method added in 7030063 and caused an UnsatisfiedLinkError > > > > http://cr.openjdk.java.net/~dholmes/jdk7-clone/webrev-7035109/ > > > > Failing test now passes. > > > > Due to the urgency this will get pushed directly into the TL PIT jdk > > > repo so that it will be paired with 7030063 and present in b138. > There is always a bit of risk pushing AWT or other client area changes > > to the TL forest as probably very few of us run those tests. The > update > the map file looks good to me. > > -Alan.
