Hi Alan, thank you for the feedback.
On Apr 11, 2011, at 2:19 PM, Alan Bateman wrote: > Lance Andersen - Oracle wrote: >> Hi all, >> >> This is a request for a review of the changes to remove the lint warnings >> for javax.sql.rowset. The diff is at >> http://cr.openjdk.java.net/~lancea/7035615 >> > In RowSetMetaDataImpl.wrap it might be better to test with > iface.isInstance(this)) rather than catching the CCE? I thought about that as well and am happy to make that change > At L937 it might be good to put the method declaration onto its own line (I > assume a newline was gobbled up at some point). will fix looks like that has been that way since day 1. > > In BaseRowSet.java I notice the constants near the top aren't indented, might > be worth fixing that "while you are in the area". Minor inconsistency but in > the new type parameters you've got a space between the types in two places, > and no space between them in the other place. I will take care of that. > > Otherwise the changes look okay to me. > > -Alan. > > PS: javac was updated recently to emit warnings for unreachable catch clauses > and one place that generates this warning is > src/share/classes/com/sun/rowset/CachedRowSetImpl.java:947. It would be great > to get that one fixed while you are fixing the other warnings. If you are OK with do it as part of this change, happy to change. Regards Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
