Michael McMahon wrote:
An updated webrev is available for this fix. I'll probably go ahead
with the CCC request for the spec. change anyway.
http://cr.openjdk.java.net/~michaelm/7034570/webrev.2/
The updated webrev looks much better. A couple of minor suggestions
- it might be useful to future maintainers if you put a comment in
before the iteration to explain why SystemRoot is needed
- it might be neater to add an append(StringBuilder sb, String key,
String value) method to append the key=value\u0000 strings rather than
doing it in two places
- the string "systemroot" is in 3 places, might be nice to make it a
constant.
Otherwise looks fine to me.
-Alan
