Hi Lance,
- logSync is not declared final.
- the comment "thow a SecurityException" is not that useful
- in getDrivers(), I think you can use an ArrayList to gather
all drivers and use Collections.enumeration() at the end.
- also instead of
if (drivers == null || drivers.equals("")) {
if (drivers == null || drivers.isEmpty()) {
should be a little more efficient.
That's all :)
Rémi
On 03/11/2011 09:18 PM, Ulf Zibis wrote:
Maybe you could update the javadoc style (<code> -> @code etc.) and
move the constructor to the begining.
-Ulf
Am 11.03.2011 21:03, schrieb Lance Andersen - Oracle:
Hi,
I have posted the diffs to DriverManager for review at
http://cr.openjdk.java.net/~lancea/7026898/. This change utilizes
CopyOnWriteArrayList instead of the Vectors previously used.
Regards,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected]
Oracle is committed to developing practices and products that
help protect the environment
