On 17:12 Wed 27 Jul , Kelly O'Hair wrote: > > On Jul 27, 2011, at 4:28 PM, Dr Andrew John Hughes wrote: > > > On 11:58 Wed 27 Jul , Kelly O'Hair wrote: > >> > >> On Jul 27, 2011, at 11:04 AM, Dr Andrew John Hughes wrote: > >> > >>> Hi, > >>> > >>> Can someone please tell me why: > >>> > >>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf4edfcd7119 > >>> > >>> reverted my earlier fix: > >>> > >>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/80368890a2a0 > >>> > >>> without any discussion? > >> > >> My apologies, the webrev should have been made public. > >> > >>> > >>> The correct fix would have been to bump the boot source language/target > >>> class > >>> versions to 7, not erase the lines altogether. > >> > >> Unfortunately, that did not work with jdk7 as a boot > > > > Why was this? I don't understand why anything would fail with javac > > -source 7 -target 7 over > > just javac. > > Basically, we never really know what the BOOT javac will accept.
I was referring more to the actual build failure when you tried this. If we're requiring 7 support as a minimum for bootstrapping, surely we know it will support this. > I assume that if we use the default for javac, that the BOOT java can run > them. This is the assumption that has not always held in my experience. Being explicit means that a newer javac can be used with an older VM. snip... > > If the BOOT jdk was jdk8, I would want these sources built for jdk8 and run > with a jdk8, > it should just work. > This seems to contradict what you're saying about the files ending up in the image. Why does it matter if they use the minimum supported version? Presumably an OpenJDK8 VM will be able to run 1.7 class files. But an OpenJDK7 VM wouldn't be able to run 1.8 class files if these are the default produced by the bootstrap javac. > -kto > > > > > >> -kto > >> > >>> -- > >>> Andrew :) > >>> > >>> Free Java Software Engineer > >>> Red Hat, Inc. (http://www.redhat.com) > >>> > >>> Support Free Java! > >>> Contribute to GNU Classpath and IcedTea > >>> http://www.gnu.org/software/classpath > >>> http://icedtea.classpath.org > >>> PGP Key: F5862A37 (https://keys.indymedia.org/) > >>> Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 > >> > > > > -- > > Andrew :) > > > > Free Java Software Engineer > > Red Hat, Inc. (http://www.redhat.com) > > > > Support Free Java! > > Contribute to GNU Classpath and IcedTea > > http://www.gnu.org/software/classpath > > http://icedtea.classpath.org > > PGP Key: F5862A37 (https://keys.indymedia.org/) > > Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
