Hi David, it would be nice to have some help on this.
I started fixing InternalError yesterday [1] and discovered that this job is for someone with much industrousness (hope the translation is somewhat correct).
First of all a quick look at [1] would be good. And most imported someone of the commiters who want to sponsor this work. Anyone interrested in supporting/guiding? -Sebastian [1] https://bugs.openjdk.java.net/attachment.cgi?id=229&action=diff) Am 08.08.2011 23:28, schrieb David Schlosnagle:
On Mon, Aug 8, 2011 at 4:57 PM, Sebastian Sickelmann <sebastian.sickelm...@gmx.de> wrote:These ones are candidates for cleanup too, but i want to discuss if someone sees a good argument to not to change to throw new InternalError(e.getMessage(),e); or throw new InternalError("Lorem ipsum",e); Also i don't completely understand why Throwable(Throwable cause) uses cause.toString() to fill the message instead of cause.getMessage(). Can someone explain to me why?If you look at Throwable.toString(), you'll see that it uses Throwable.getLocalizedMessage() which allows for localized exception messages, so I would avoid using getMessage() directly. I'd also be interested in helping out making the Throwable and Exception types provide the 4 consistent constructors if there are committers that would help guide us. - Dave
