Ulf,
I tried to be conservative to not touch the source code, just in case I
might be forced
to put them back again:-) But since I have already removed the whole
sun.io source
branch, it's reasonable to do the complete cleanup up as well. The
webrev has been
updated accordingly (to remove those comments and methods)
http://cr.openjdk.java.net/~sherman/6237353/webrev
<http://cr.openjdk.java.net/%7Esherman/6237353/webrev/>
Thanks!
-Sherman
On 08/17/2011 05:37 AM, Ulf Zibis wrote:
As a consequence, allmost all classes in sun.nio.cs and templates in
make/tools/CharsetMapping could be made package private, at least all
access to the mapping tables!
... and don't forget to remove in each sun.nio.cs class and template:
/**
* These accessors are temporarily supplied while sun.io
* converters co-exist with the sun.nio.cs.{ext} charset coders
* These facilitate sharing of conversion tables between the
* two co-existing implementations. When sun.io converters
* are made extinct these will be unncessary and should be removed
*/
public String getDecoderSingleByteMappings() {
return b2cTable;
}
public short[] getDecoderIndex1() {
return Decoder.index1;
}
public String[] getDecoderIndex2() {
return Decoder.index2;
}
public short[] getEncoderIndex1() {
return Encoder.index1;
}
public String[] getEncoderIndex2() {
return Encoder.index2;
}
Additionally, you could mention my wrapper classes [1] in the
WORKAROUND section of bug 6237353
[1]
http://java.net/projects/java-nio-charset-enhanced/sources/svn/show/trunk/src/sun/io/
-Ulf
