Xueming Shen wrote:
:

Fix has been verified/test manually with existing test cases. Given the nature
of the > 4G zip data file. I'm not including an auto regression test.

Webrev is at

http://cr.openjdk.java.net/~sherman/7077769/webrev
The zip64 fix looks okay to me. The fix to sync() is okay too although I would change this to use try-with-resources.

On the test, I agree an automated test might be too slow to run. However, as zip64 is tricky to get right then having a sanity test in the test tree (without a @test tag) would be useful.

-Alan

Reply via email to