On 23/11/2011 13:29, Neil Richards wrote:
:
Thanks for all your guidance on this.

I've uploaded another webrev [1], incorporating David's suggested ARM
correction (thanks) and Chris' suggested handling of
InterruptedException (together a System.out.println(), for clarity).

Looks fine to me too. I think your original try-with-resources usage was fine too because the ZipOutputStream constructor doesn't throw any exceptions (except perhaps a resource issue in the event that we're out of memory for example).

-Alan.

Reply via email to