On 02/12/11 10:31, Sergey Malenkov wrote:
I approve changes with a small update.
java/beans/VetoableChangeSupport.java:
- Hashtable<String, VetoableChangeSupport> children =
(Hashtable<String, VetoableChangeSupport>) fields.get("children", null);
+ @SuppressWarnings("unchecked")
+ Hashtable<String, VetoableChangeSupport> children =
(Hashtable<String, VetoableChangeSupport>)fields.get("children", null);
There is not necessary to remove a space because of the Java code
conventions:
http://www.oracle.com/technetwork/java/codeconventions-141388.html#682
It is preferable to use the jdk8/awt ws, because the jdk8/swing one is
not supported anymore. I think that the jdk8/tl ws is also fine to push.
I already pushed the changeset as it was - if you'd like me to go back
and fix the whitespace issue, let me know.
Thanks
Maurizio
Thanks,
SAM
On 01.12.2011 21:13, Andrey Pikalev wrote:
Typically JavaBeans changes went into Swing (now AWT) gate. I don't
think this really matter where to push this time assuming the changes
will be propagated to AWT repo in a few weeks.
Thanks,
Andrey.
On 12/1/2011 9:04 PM, Alan Bateman wrote:
On 01/12/2011 16:33, Maurizio Cimadamore wrote:
Updated version [1].
Changes:
*) Beans.java:184 - generified PrivilegedAction
*) Beans.java:284 - generified PrivilegedAction
*) NameGenerator.java:108 - changed Object to Integer and removed
following cast
*) Introspector.java: added new fake local variable to reduce scope of
@SuppressWarnings
[1] - http://cr.openjdk.java.net/~mcimadamore/7116954.1/
<http://cr.openjdk.java.net/%7Emcimadamore/7116954.1/>
These changes look fine to me.
Now the question is where to push this, jdk8/tl or jdk8/awt? My
guess is
that the beans activity these days is very low these days so if
jdk8/awt
doesn't see it for weeks then it wouldn't matter. Hopefully Sergey
Malenkov will chime.
-Alan
