On 01/12/2011 21:47, Xueming Shen wrote:
Please help review the change at
http://cr.openjdk.java.net/~sherman/6907367/webrev
The proposed change does not include the test case I was originally
planed
as showed at
http://cr.openjdk.java.net/~sherman/6907367/webrev.00/test/com/sun/tools/extcheck/TestExtcheckArgs.java.sdiff.html
The test case will failed if run against the current jdk8 build image
because
all those jar files still have their "specification-version" listed as
"1.7", as
-----------------------------------
Manifest-Version: 1.0
Implementation-Vendor: Oracle Corporation
Implementation-Title: Java Runtime Environment
Implementation-Version: 1.8.0-internal
Specification-Vendor: Oracle Corporation
Created-By: 1.7.0 (Oracle Corporation)
Specification-Title: Java Platform API Specification
Specification-Version: 1.7
------------------------------------
in which case the test case fails when comparing the version.
While I should be able to figure out "where and how" in those release
makefiles to fix
this, it appears all system jar files will be replaced bye "modules"
in jdk8 anyway, the
extcheck on system jar files will become much less relevant (as Alan
suggested). So
I decided to leave the test case out (I did run the test case manually
to verify the fix).
The manifest that is used is make/tools/manifest.mf, it just hasn't been
updated to 1.8 yet. The proposed change is fine and I think it's better
to hold off on a test until it becomes clear how the extensions
mechanism is going to work in jdk8. As you mentioned, modules are
coming, and the extensions mechanism will only make sense in legacy mode.
-Alan.
