On 12/08/2011 01:25 PM, Stuart Marks wrote:
On 12/8/11 8:25 AM, Omair Majid wrote:
On 12/7/11 3:13 PM, Omair Majid wrote:
You have commit rights, don't you? I'd say it's OK to proceed with the
push. Or, if you prefer, Alan should be online in just a couple hours,
and I'm sure he can give the final go-ahead.
Yes, I do have commit rights and I would be more than happy to push the
changeset. One quick question, if you dont mind. Does this comment
look fine?
7117612: Miscellaneous warnings in java.lang
Reviewed-by: smarks, dholmes, alanb
Shall I add Joe Darcy to the list of reviewers too? He did make a
comment on
AutoClosable, but I am not sure if he was a 'reviewer'.
Comment looks fine overall.
I don't know if there are any hard-and-fast rules about what constitues
a reviewer. My style is to be fairly inclusive. Joe's comment made a
significant point about a specific issue, so I'd include him (darcy) on
the Reviewed-by: line. (BTW I need to follow up on this issue with the
compiler team, and possibly file a bug on it.)
Thank you very much for all your help.
I have pushed the changeset:
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8897baf40ea
Thanks,
Omair
