Hi Chris and Remi, Thank you very much :-)
Regards, Kris Mok On Tue, Jan 10, 2012 at 6:58 PM, Rémi Forax <fo...@univ-mlv.fr> wrote: > On 01/10/2012 11:43 AM, Chris Hegarty wrote: > >> I created CR 7128584: "Typo in sun.misc.VM's private directMemory field >> comment", for this issue, and will push Kris' change with Remi and myself >> as reviewer and listing Kris as the contributor. >> >> Thanks, >> -Chris. >> > > Thanks, > Rémi > > > >> On 01/10/12 08:22 AM, Rémi Forax wrote: >> >>> I think it's better if it has it's own bug id and changeset. >>> I'm sure Joe can create a bug id for it. >>> >>> Rémi >>> >>> On 01/10/2012 06:51 AM, Krystal Mok wrote: >>> >>>> Hi all, >>>> >>>> Just found a little typo in sun.misc.VM: >>>> >>>> diff -r 00e2c88e2234 src/share/classes/sun/misc/VM.**java >>>> --- a/src/share/classes/sun/misc/**VM.java Thu Nov 17 10:46:02 2011 >>>> -0800 >>>> +++ b/src/share/classes/sun/misc/**VM.java Tue Jan 10 13:42:52 2012 >>>> +0800 >>>> @@ -167,7 +167,7 @@ >>>> // >>>> // The initial value of this field is arbitrary; during JRE >>>> initialization >>>> // it will be reset to the value specified on the command line, if any, >>>> - // otherwise to Runtime.getRuntime.**maxDirectMemory(). >>>> + // otherwise to Runtime.getRuntime().**maxMemory(). >>>> // >>>> private static long directMemory = 64 * 1024 * 1024; >>>> >>>> >>>> I was looking for the default max direct memory size when I found this >>>> comment. It would have been nice if this typo was fixed in 6977738. [1] >>>> Could anybody include this fix in some future commits? >>>> >>>> Regards, >>>> Kris Mok >>>> >>>> [1]: >>>> http://hg.openjdk.java.net/**jdk8/jdk8/jdk/rev/b444f86c4abe<http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/b444f86c4abe> >>>> >>> >>> >
