Thanks for the quick review!
Now, if only I can get the approval today, I can actually catch the code
freeze... :)
--Joe
On 3/21/2012 5:26 AM, Lance Andersen - Oracle wrote:
Thank you Joe, good to go from my perspective.
Best
Lance
On Mar 20, 2012, at 11:36 PM, Joe Wang wrote:
Thanks Lance!
On 3/20/2012 2:44 PM, Lance Andersen - Oracle wrote:
Hi Joe,
This looks Ok, a couple of minor comments:
- SerializationHandler.java could use a comment before the method
setIsStandalone().
Added the following comment:
/**
* Specify if the output will be treated as a standalone property
* @param isStandalone true if the
http://www.oracle.com/xml/is-standalone is set to yes
* @see OutputPropertiesFactory ORACLE_IS_STANDALONE
*/
public void setIsStandalone(boolean isStandalone);
- ToXMLStream.java seems to have a typo in the comment
/**
331 * Before Xalan 1497, a newline char was
printed out if not inside of an
332 * element. The whitespace is not significant
is the output is standalone
^^^
333 */
Corrected the typo: "is" should have been "if"
The updated webrev:
http://cr.openjdk.java.net/~joehw/7u4/cr7150537/webrev/
<http://cr.openjdk.java.net/%7Ejoehw/7u4/cr7150537/webrev/>
<http://cr.openjdk.java.net/%7Ejoehw/7u4/cr7150537/webrev/>
Regards,
Joe
Best
lance
On Mar 20, 2012, at 1:32 PM, Joe Wang wrote:
Hi,
This is an issue introduced by an Apache update that although
technically correct, was nonetheless an incompatible change. As
reported in the CR, it caused NetBeans test failures and spurious
reformatting of project metadata of users' projects that the
version control tool would take as if there were real changes. The
incompatible behavior would more than likely cause many problems to
users' applications as did to the JAXP SQE tests.
Jesse Glick of the NetBeans tried manually or using 3rd party tool
to work around the issue, but none satisfactorily.
This patch adds an implementation specific property that can be
used to essentially neutralize the Apache change to bring back the
original behavior. It has been tested, to Jesse's satisfactory, to
have resolved the NetBeans issue with minimal effect in the
NetBeans' part.
The use is:
transformer.setOutputProperty("http://www.oracle.com/xml/is-standalone";,
"yes");
Below is the webrev:
http://cr.openjdk.java.net/~joehw/7u4/cr7150537/webrev/
<http://cr.openjdk.java.net/%7Ejoehw/7u4/cr7150537/webrev/>
<http://cr.openjdk.java.net/%7Ejoehw/7u4/cr7150537/webrev/>
Please review.
Thanks,
Joe
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
<mailto:lance.ander...@oracle.com>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
