Looks OK to me Best Lance On Apr 12, 2012, at 4:09 PM, Xueming Shen wrote:
> Hi > > Please help review the change for 7067045. > > The change is to throw a more meaningful IAE instead of the > StringIndexoutputOfBoundsException > if backslash or $ is the last character in the replacement string. (as the > API indicated, the backslash > and $ character in String's regex replacement and Matcher class have special > meanings, backslash > is for literal character escape and the $ is the capturing group reference, > which needs a group index). > > http://cr.openjdk.java.net/~sherman/7067045/webrev/ > > Thanks, > -Sherman Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
