On 04/13/2012 04:45 PM, Alan Bateman wrote:
On 13/04/2012 03:21, Charles Lee wrote:
On 04/12/2012 04:26 PM, Alan Bateman wrote:
On 12/04/2012 08:22, Deven You wrote:
I have verified this commit. Thanks Alan and Charles!
The change-set that Charles pushed added test/sun/tools/classpath/
RMICClassPathTest.java but I didn't see it in the original webrev. I
see now that your original mail had the proposed test in a separate
webrev but I missed that. Anyway, one comment is that test has been
added to an odd location that doesn't correspond to where the fix
was made. I think test/sun/rmi/rmic would have been a more suitable
location.
-Alan.
Hi Alan,
I am sorry for that. Should I commit a revert changeset?
I would suggest just moving it (hg mv) to test/sun/rmi/rmic as it's a
really test for sun.rmi.rmic.BatchEnvironment. I've created a bug that
you can use:
7161282: Move test/sun/tools/classpath/RMICClassPathTest.java to a
more appropriate location
-Alan.
Hi Alan,
The patch is @ http://cr.openjdk.java.net/~littlee/7161282/webrev.00/
<http://cr.openjdk.java.net/%7Elittlee/7161282/webrev.00/>
Please help reviewing it :-)
--
Yours Charles
