Hi Lance,
On 6/7/2012 2:13 PM, Lance Andersen - Oracle wrote:
Thanks Chris, Alan, Joe, Mandy.
Joe I will update the copyright but will not plan on a webrev for that..
Sure.
I thought line 470 was readable
ClassLoader cl = cc != null ? cc.getClassLoader() : null;
I would have written this as
ClassLoader cl = (cc != null) ? cc.getClassLoader() : null;
The other reviewers accepted the old version so I'll leave it to your
discretion about whether to change it or not.
Cheers,
-Joe
I would prefer to get this back for now vs. make that change as part of an
additional cleanup i have planned to DriverManager.
as if I do this now, I would want to do another full build and run of all of
the tests. I know Alan would like this back for jigsaw sooner rather than
later.
I think I can streamline this code some more but would like to get this back
(as well as my other week old review requests ;-) ).
Are you Ok with just the copyright change for now?
Best
Lance
On Jun 7, 2012, at 4:49 PM, Mandy Chung wrote:
Looks good. It's a good clean up.
Mandy
On 6/7/2012 11:47 AM, Lance Andersen - Oracle wrote:
Hi all,
Another review request (to go with the others that are outstanding).
This is change is for jigsaw, where we are removing the native code used by
DriverManager. The webrev can be found at:
http://cr.openjdk.java.net/~lancea/7172551/webrev.00
Best,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected]
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected]
