Hi Sean, I think this looks good. ship it :-)
Best Lance On Jun 25, 2012, at 4:26 PM, Sean Coffey wrote: > Hi, > > I'm looking for a code review around the following corba changes. It turns > out that we've a few bug fixes in corba area for jdk6 that were never forward > ported to jdk7 or 8. The port is pretty much identical to what was used in > JDK6. Some formatting and diamond operator changes introduced but that's > about it. There were a few bug fixes to follow up on regressions around the > initial fix but this umbrella port should cover all issues. > > The initial bugs fixes were fixed under the "jets" category in the bug tool > and that category entered read only mode over a year ago. Hence the > requirement for a new bug ID. > > The main bug fix is 6725987 which is an issue where references to the ORB > were being kept after ORB.destroy was called. > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7162902 > An accompanying CNCtx fix in JDK repo is also made to correct an issue where > the java.naming.corba.orb system property wasn't used correctly. (CR 6893617) > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6893617 > > Corba testsuites run and no issues seen. I've also run some JCK testing and > saw no issues. > > http://cr.openjdk.java.net/~coffeys/webrev.7162902.jdk8/ (corba) > http://cr.openjdk.java.net/~coffeys/webrev.6893617.jdk8/ (jdk) > > The corba codebase code formatting seems to vary quite a bit. I've > reformatted in a small number of areas but the whole corba repo probably > warrants it's own clean up project at a later date. > > regards, > Sean. Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
