Looks fine to me.  Thanks for tracking it down.

I'll push the changeset for you.

-Chris.

On 19/07/12 09:54, Eric Wang wrote:
Hi Chris,

Please help to review the fix for 7081476
<http://monaco.us.oracle.com/detail.jsf?cr=7081476>:
test/java/net/InetSocketAddress/B6469803.java failing intermittently.
http://dl.dropbox.com/u/90659131/fixes/7081476/webrev/index.html

The test failed when it is running with
java/net/DatagramPacket/ReuseBuf.java concurrently. As discussed, the
root cause is:
1. The call InetAddress.getByName("LocalHost") in ReuseBuf.java
generates the address entry which hostname is "LocalHost" and put it
with lowercase key "localhost" into InetAddress cache.
2. if the test B6469803.java executes concurrently, the call new
InetSocketAddress("localhost", 12345) lookups the InetAddress cache by
using the key "localhost", it can find the result in cache which
hostname is "LocalHost", so the test fails as the expected value is
"localhost".

Regards,
Eric

Reply via email to