Hi David,
To use dirFile.length() == 0 to replace the disk space measurement as
guess the original test tries to prove that there's no extra disk spent
when creating empty folders.
Regards,
Eric
On 2012/8/22 16:02, David Holmes wrote:
Hi Eric,
On 22/08/2012 5:54 PM, Eric Wang wrote:
Please help to review the fix below for bug **6962637
<http://monaco.us.oracle.com/detail.jsf?cr=6962637> TEST_BUG:
java/io/File/MaxPathLength.java may fail in busy system
http://dl.dropbox.com/u/90659131/fixes/6962637/webrev/index.html
Root cause is the test is not reliable when system is busy, if disk
space is changed by some other program, test can fail. so the fix is to
check file.length() instead of disk space.
I can not figure out what the original version of the test was doing
with the disk space measurements but I can certainly appreciate that
they could be changing dynamically while the test is running.
But I don't really understand why dirFile is expected to have a zero
length ???
David
Regards,
Eric
