Mandy,
1. You replace null with getClassLoader() calls in couple of places.
getClassLoader requires special permissions -
RuntimePermission("getClassLoader")
so probably you need to use doPrivileget() there.
Did you test your changes with SecurityManager/No permissions
for the test ?
2. Did you consider moving
sm.checkPermission(SecurityConstants.GET_CLASSLOADER_PERMISSION);
inside ClassLoader.needsClassLoaderPermissionCheck(ccl, cl); ?
3. ManagementFactory.java
Could you explain the reason of changes (except 588) ?
-Dmitry
On 2012-08-23 23:33, Mandy Chung wrote:
> On 8/23/2012 11:58 AM, Alan Bateman wrote:
>> On 23/08/2012 18:43, Mandy Chung wrote:
>>> This change is to bring the jdk modularization changes from jigsaw
>>> repo [1]
>>> to jdk8. This allows the jdk modularization changes to be exposed for
>>> testing as early as possible and minimize the amount of changes carried
>>> in the jigsaw repo that helps sync up jigsaw with jdk8/jdk9.
>>>
>>> Webrev at:
>>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7193339/webrev.00/
>>>
>> This looks good to me and it's good to have these changes in jdk8.
>>
>> One suggestion for ReflectUtil is to add a private static boolean
>> isAncestor method as I think that would make the checks in
>> needsPackageAccessCheck easier to read. Also in ClassLoader you could
>> use just use needsClassLoaderPermissionCheck(from,to).
>>
>
> Done. This is a good cleanup I considered to do too but missed in the
> previous webrev.
>
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7193339/webrev.01/
>
> Thanks for the review.
> Mandy
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
