On 8/29/12 3:50 AM, Ulf Zibis wrote:
In FilePermission.java file, I make one change to its method
signature,
public Enumeration elements() ==> public Enumeration<Permission>
elements()
Actually the whole method is synchronized. To make this more clear, I suggest:
798 public synchronized Enumeration<Permission> elements() {
799 // Convert Iterator into Enumeration
800 return Collections.enumeration(perms);
801 }
[...]
If this class is package-private, why the constructor is public?
(please also check all other methods, especially if not inherited)
[...]
Please check indentations and tabs -> spaces, while you are here.
E.g. following lines should be: [...]
[...]
I only took a short look on class FilePermission.java, but not the others of
this CR for now.
Hi Ulf,
You're making some reasonable suggestions for general code cleanup. However,
this is not general code cleanup. Several issues have already been raised that
are directly relevant to the warnings fixes. I'd like to get these resolved, to
get Dan's fix integrated, and to keep Dan focused on further warnings cleanup,
without getting bogged down in other code cleanup issues.
Thanks.
s'marks
