On 1/10/2012 6:53 PM, Alan Bateman wrote:
On 01/10/2012 08:20, David Holmes wrote:
Hi Alan,
This one caught my eye:
src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java
This entire class seems to re-declare inherited methods from
DatagramSocketImpl for no obvious reason and mess up the javadoc in
the process. In many/most cases there is no need to redeclare the
methods AFAICS. If there is some subtle reason then inheritance of the
existing javadoc should suffice in the majority of cases.
I agree. I talked to Chris about it as it's left over from the
refactoring of the socket impls. As these are package-private classes
and don't show up in the javadoc I decided to do the minimum and just
fix up the @param tags. I create a separate issue to sort out the socket
impl docs.
In that case you should fix:
102 * @param p to be sent.
->
* @param p the packet to be sent.
David
-----
-Alan
