Re: Reviewer needed for 8000763: use XXX.valueOf methods instead of constructors

Remi Forax Thu, 11 Oct 2012 10:09:07 -0700

On 10/11/2012 06:45 PM, Lance Andersen - Oracle wrote:

Hi,


Need a review for changing to use the XXX.valueOf methods from constructors.

Thank you

Best
Lance


Hi Lance,
in CachedRowSetImpl, the code is equivalent to
  return Double.compare(Double.parseDouble(value.toString()), 0) != 0;
which avoid to create the Double objects.

the rest looks good.

cheers,
Rémi




new-host-2:rowset lanceandersen$ hg status -m
M src/share/classes/com/sun/rowset/CachedRowSetImpl.java
M src/share/classes/com/sun/rowset/FilteredRowSetImpl.java
M src/share/classes/javax/sql/rowset/BaseRowSet.java
M src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java

new-host-2:rowset lanceandersen$ hg diff
diff -r c2be39b27e1c src/share/classes/com/sun/rowset/CachedRowSetImpl.java
--- a/src/share/classes/com/sun/rowset/CachedRowSetImpl.java    Thu Oct 11 
11:47:05 2012 +0100
+++ b/src/share/classes/com/sun/rowset/CachedRowSetImpl.java    Thu Oct 11 
12:43:57 2012 -0400
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2003, 2012, Oracle and/or its affiliates. All rights reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -1747,7 +1747,7 @@
          // convert to a Double and compare to zero
          try {
              Double d = new Double(value.toString());
-            if (d.compareTo(new Double((double)0)) == 0) {
+            if (d.compareTo(Double.valueOf(0)) == 0) {
                  return false;
              } else {
                  return true;
@@ -4432,7 +4432,7 @@
          // make sure the cursor is on a valid row
          checkCursor();

- Object obj = convertNumeric(new Float(x),

+        Object obj = convertNumeric(Float.valueOf(x),
          java.sql.Types.REAL,
          RowSetMD.getColumnType(columnIndex));

@@ -4467,7 +4467,7 @@

          checkIndex(columnIndex);
          // make sure the cursor is on a valid row
          checkCursor();
-        Object obj = convertNumeric(new Double(x),
+        Object obj = convertNumeric(Double.valueOf(x),
          java.sql.Types.DOUBLE,
          RowSetMD.getColumnType(columnIndex));

diff -r c2be39b27e1c src/share/classes/com/sun/rowset/FilteredRowSetImpl.java

--- a/src/share/classes/com/sun/rowset/FilteredRowSetImpl.java  Thu Oct 11 
11:47:05 2012 +0100
+++ b/src/share/classes/com/sun/rowset/FilteredRowSetImpl.java  Thu Oct 11 
12:43:57 2012 -0400
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2003, 2012, Oracle and/or its affiliates. All rights reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -839,7 +839,7 @@

if(onInsertRow) {

           if(p != null) {
-            bool = p.evaluate(new Float(x) , columnIndex);
+            bool = p.evaluate(Float.valueOf(x) , columnIndex);

if(!bool) {

                 throw new 
SQLException(resBundle.handleGetObject("filteredrowsetimpl.notallowed").toString());
@@ -906,7 +906,7 @@

if(onInsertRow) {

           if(p != null) {
-            bool = p.evaluate(new Double(x) , columnIndex);
+            bool = p.evaluate(Double.valueOf(x) , columnIndex);

if(!bool) {

                 throw new 
SQLException(resBundle.handleGetObject("filteredrowsetimpl.notallowed").toString());
diff -r c2be39b27e1c src/share/classes/javax/sql/rowset/BaseRowSet.java
--- a/src/share/classes/javax/sql/rowset/BaseRowSet.java        Thu Oct 11 
11:47:05 2012 +0100
+++ b/src/share/classes/javax/sql/rowset/BaseRowSet.java        Thu Oct 11 
12:43:57 2012 -0400
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2003, 2012, Oracle and/or its affiliates. All rights reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -1850,7 +1850,7 @@
          if(params == null){
               throw new SQLException("Set initParams() before setFloat");
          }
-        params.put(Integer.valueOf(parameterIndex - 1), new Float(x));
+        params.put(Integer.valueOf(parameterIndex - 1), Float.valueOf(x));
      }

/**

@@ -1882,7 +1882,7 @@
          if(params == null){
               throw new SQLException("Set initParams() before setDouble");
          }
-        params.put(Integer.valueOf(parameterIndex - 1), new Double(x));
+        params.put(Integer.valueOf(parameterIndex - 1), Double.valueOf(x));
      }

/**

diff -r c2be39b27e1c 
src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java
--- a/src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java      Thu Oct 
11 11:47:05 2012 +0100
+++ b/src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java      Thu Oct 
11 12:43:57 2012 -0400
@@ -215,7 +215,7 @@
       */
      @SuppressWarnings("unchecked")
      public void writeFloat(float x) throws SQLException {
-        attribs.add(new Float(x));
+        attribs.add(Float.valueOf(x));
      }

/**

@@ -230,7 +230,7 @@
       */
      @SuppressWarnings("unchecked")
      public void writeDouble(double x) throws SQLException{
-        attribs.add(new Double(x));
+        attribs.add(Double.valueOf(x));
      }

/**

new-host-2:rowset lanceandersen$

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com

Re: Reviewer needed for 8000763: use XXX.valueOf methods instead of constructors

Reply via email to