Alan,
I grepped the patch and it seems to be ok.
You can add me as a reviewer.
Kumar
Now for some noise.
The copyright date in the source files needs updating. The man behind
the curtain is Steve Sides from the Quality and Release Engineering
team in Oracle. Jon pushed, on Steve's behalf, the update to the
langtools files recently [1], and Mikael updated hotspot [2]. The
elephant is the jdk repository as there are 3000+ files that need
their headers updated.
To keep the disruption to a minimum I propose that we do the jdk
repository in two steps: non-client area now to jdk8/tl, and then the
client-area later in jdk8/awt once the changes get there. I use the
term "client-area" loosely to mean the source files for awt, swing,
font, java2d, etc. (and I appreciate that there is also a jdk8/2d
forest in use). To that end here is the proposed patch for today:
http://cr.openjdk.java.net/~alanb/7197491/copyright.patch
This patch updates the headers on 2370 files. I don't propose to
publish a webrev as it's just too big.
This patch was created with:
cd jdk
sh ../make/scripts/update_copyright_year.sh 2011
sh ../make/scripts/update_copyright_year.sh 2012
hg revert --no-backup `cat clientdirs.list`
hg diff -g > copyright.patch
where clientdirs.list is most of the directories corresponding to the
client area.
Note that I ran the update_copyright_year.sh script twice, once for
2011 and then a second time for 2012. The reason for this is that
there are several hundred files in the jdk repository that were last
updated in 2011 but have an older date on the header.
Reviewer welcome but I should say that I don't have cycles to spend on
this. Also the patch has an a very short shelf life.
Finally, I think that there needs to be wider discussion as to how to
keep the headers from falling behind too much. Some people do update
the headers when editing files, some people (including myself) do not.
It seems to me that it should be done regularly anyway, perhaps every
few months or at integration time every so often.
-Alan.
[1] http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9d47f4850714
[2] http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b9a9ed0f8eeb
