On 30/11/2012 23:19, Jim Gish wrote:
Please review
http://cr.openjdk.java.net/~jgish/Bug8003596-CheckLockLocationTest-Windows-fix/
<http://cr.openjdk.java.net/%7Ejgish/Bug8003596-CheckLockLocationTest-Windows-fix/>
Summary: fixes test when running on Windows so that test that requires
setWritable is not run, because Windows does not support setWritable.
Thanks,
Jim
Looks okay to me although "if (!isWindows())" to "if (!ON_WINDOWS)"
might be neater. An alternative way to do this would be just to handle
check the return from setWritable rather than failing. It is possible to
change the deny adding entries to directories with the new file system
API but it's probably not worth using it here.
-Alan.
