On 12/06/2012 11:02 AM, Remi Forax wrote:

just nitpicking,
    return new SuppliedThreadLocal<T>(supplier);
should be
    return new SuppliedThreadLocal<>(supplier);

Also, can you add a @see in the constructor of ThreadLocal that
references ThreadLocal.withInitialValue(Supplier).

http://cr.openjdk.java.net/~akhil/8003246.3/webrev/

also incorporates a nitpick from Mike -
  Objects.requireNonNull returns its arg

Thanks - nitpicking welcome :)

Reply via email to