On Dec 11, 2012, at 1:24 PM, Alan Bateman <alan.bate...@oracle.com> wrote:
> > Joe sent me an update with changes to address issues discussed so far, I've > put the webrev here: > > http://cr.openjdk.java.net/~alanb/8004371/webrev.02/ > > Joe - the classes you sent me were in different packages, also the formatting > was a bit messed up in several classes, I've fixed up those issues so you may > need to re-base from the patch file included in the webrev. > http://cr.openjdk.java.net/~alanb/8004371/webrev.02/src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java.html Why are the element qualified names compared ignoring case? -- http://cr.openjdk.java.net/~alanb/8004371/webrev.02/src/share/classes/java/util/Properties.java.sdiff.html What if there is a ServiceConfigurationError thrown in loadProviderAsService? Need to be very careful of errors on static initialization of the Properties class. -- We need tests with invalid documents. I did not check if there are already such tests present. Paul.
