On 19/12/2012 7:29 AM, Jim Gish wrote:
Excuse me, a "comma".

On 12/18/2012 04:20 PM, Jim Gish wrote:
Code looks good, Joe. There is just one grammatical nit with the comment:

* A default method is a non-abstract method, that is a method with
512 * a body, declared in an interface type.

Actually I think it would be more correct to parenthesize this as it is an aside comment:

"A default method is a non-abstract method (that is, a method with a body) declared in an interface type."

But the JLS reference should go here rather than on the @return:

"A default method (JLS XXX) is a non-abstract method (that is, a method with a body) declared in an interface type."

David
-----



"that is" should have a comment after it.

Thanks,
Jim

On 12/18/2012 03:43 PM, Joe Darcy wrote:
Hello,

Please review these changes to add core reflection support to
recognize default methods:

8005042 Add Method.isDefault to core reflection
http://cr.openjdk.java.net/~darcy/8005042.0/

Thanks,

-Joe


--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com

Reply via email to