On 18/12/2012 18:04, marti...@google.com wrote:
Changeset: 0fabdf676395
Author:    martin
Date:      2012-12-17 18:39 -0800
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0fabdf676395

8004863: Infinite Loop in KeepAliveStream
Reviewed-by: chegar

! src/share/classes/sun/net/www/http/KeepAliveStream.java
+ test/sun/net/www/http/KeepAliveStream/InfiniteLoop.java

Good to see you back!

One little nit, this change is in area where warnings are fatal so if KeepAliveStream isn't compiled implicitly early in the build then the cast added in this change is fatal, see:

../../../../src/share/classes/sun/net/www/http/KeepAliveStream.java:86: warning: [cast] redundant cast to long
                    do {} while ((nskip = (long) (expected - count)) > 0L
                                          ^
error: warnings found and -Werror specified
1 error
1 warning

We should probably whack it while it is fresh.

-Alan.

Reply via email to