On 21/12/2012 09:40, Sean Chou wrote:
Hello,
We found -fsigned-char is added to ppc platform, but not added to ppc64
platform. As they are different platforms, I think it is needed for ppc64
as well. Currently I just added one line modification as follow, but there
may be more places to modify. If some one can give some comments, I can
make a complete webrev.
The buggy scenario we found needs closed code to reproduce, so it is not
reproduced with current openjdk build on ppc linux from AIX porting
project. I tested with ibmjdk, the patch works.
I found CFLAGS_REQUIRED_ppc is from changeset
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/54d8193f177b . Is it enough
to add ppc64 option for places ppc appears in that patch?
///////////////////////// the patch ////////////////////////
diff --git a/make/common/Defs-linux.gmk b/make/common/Defs-linux.gmk
--- a/make/common/Defs-linux.gmk
+++ b/make/common/Defs-linux.gmk
@@ -196,6 +196,7 @@
LDFLAGS_COMMON_sparc += -m32 -mcpu=v9
CFLAGS_REQUIRED_arm += -fsigned-char -D_LITTLE_ENDIAN
CFLAGS_REQUIRED_ppc += -fsigned-char -D_BIG_ENDIAN
+CFLAGS_REQUIRED_ppc64 += -fsigned-char -D_BIG_ENDIAN
ifeq ($(ZERO_BUILD), true)
CFLAGS_REQUIRED = $(ZERO_ARCHFLAG)
ifeq ($(ZERO_ENDIANNESS), little)
You should probably bring this to build-dev to discuss. If the
linux-ppc64 port is a jdk8 port then you should probably be looking at
the new build and we should be cutting over soon.
-Alan
