On 12/21/2012 11:08 AM, Alan Bateman wrote:
On 21/12/2012 18:03, Joe Wang wrote:
:
Files are renamed. I added a new test "CompatibilityTest" to test
behavior compatibility with the regular JDK XML provider.
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8005280/webrev/
-Joe
Thanks for renaming the propertyfile_ prefix from the new test cases,
looks much cleaner now.
On Compatibility.xml then I guess it should very rare to use this for
Properties. I guess the test is okay, just wondering about require the
small parser to support it.
I searched by properties.dtd and found the CDATA usage. So I went ahead
experimenting what would not be rejected by the regular provider and
tested against the small parser. I agree the cases other than CDATA are
rare.
In CompatibilityTest.loadPropertyFile then it looks like the file is
not closed.
Properties' loadFromXML stated that it will close the stream after
loading. But it doesn't hurt to double-check.
New webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8005280/webrev/
-Joe
-Alan
