On 1/9/2013 7:26 AM, Alan Bateman wrote:
On 09/01/2013 15:03, Kumar Srinivasan wrote:
Generally the changes looks good, I focused on pack200 and launcher,
the src changes are fine.
Some comments on the tests in test/tools/launcher/profiles, we have a
test/tools/launcher/TestHelper.java which could make these new launcher
tests in the profile directory simpler.
Kumar
Thanks for looking at this.
The reason that these tests are not using TestHelper it uses
sun.tools.jar (the "jar" tool) and this is not in any of the runtime
profiles. It also uses javax.compiler and this is only proposed for
compact3 (even then it is only functional if tools.jar is copied in).
At one point I looked into doing refactoring but decided it would be
better to re-examine once the changes are in jdk8/tl. I hope that is
okay with you.
Ah ok sounds good. I think we should make this fool proof after CF
to prevent nightly test anomalies by someone introducing stray dependencies.
Thanks
Kumar
-Alan.
