On 01/10/2013 08:40 PM, Chris Hegarty wrote: > Doug, Aleksey, > > I updated the appropriate methods in the Atomic classes to use the > instinsics defined by 7023898 , Unsafe getAndAddInt, getAndSetInt, > getAndAddLong, getAndSetLong, getAndSetObject. > > http://cr.openjdk.java.net/~chegar/8006007/webrev.00/webrev/
Good. Two comments: a) Any java-concurrency-torture [1] failures for these classes? b) Can we delegate all the suitable methods to Unsafe directly, without calling the middleman (i.e. getAndDec() -> getAndAdd() -> unsafe), as in [2]? -Aleksey. [1] https://github.com/shipilev/java-concurrency-torture/ [2] https://github.com/shipilev/java-concurrency-torture/blob/master/src/main/java/org/openjdk/util/concurrent/atomic/AtomicIntegerV8.java
