Looks good (but I'm not a reviewer-kind of reviewer). cheers /Joel
On Feb 1, 2013, at 10:28 PM, Joe Darcy <[email protected]> wrote: > On 02/01/2013 11:16 AM, Joe Darcy wrote: >> Hi Joel, >> >> On 2/1/2013 1:47 AM, Joel Borggrén-Franck wrote: >>> Hi Joe, >>> >>> On 02/01/2013 04:21 AM, Joe Darcy wrote: >>>> Hello, >>>> >>>> I'd like to upgrade the existing AnnotatedElement.isAnnotationPresent >>>> interface method to a default method: >>>> >>>> 8007113 Upgrade AnnotatedElement.isAnnotionPresent to be a default >>>> method >>>> http://cr.openjdk.java.net/~darcy/8007113.0/ >>>> >>> >>> How about sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ? >>> >>> It looks like I forgot to update that one when I did the type annotations >>> changes :) >> >> I did notice TypeVariableImpl as one of the implementers of >> AnnotatedElement, but since it was defined to just return false, I skipped >> it. However, since getAnnotation now works for type variables, that >> behavior is incorrect. >> >> I'll update the webrev to cover TypeVariableImpl too. >> >> Thanks, >> > > New webrev posted with a typo fix and TypeVariableImpl covered: > > http://cr.openjdk.java.net/~darcy/8007113.1/ > > Thanks, > > -Joe >
