Drat, I made a mistake, sorry!, I used the wrong JBS id for this push,
to keep it simple
and avoid confusion I will swap the jbs ids, and add some comments in
jbs as well.
Kumar
On 2/10/2013 2:55 AM, Alan Bateman wrote:
On 09/02/2013 18:09, Kumar Srinivasan wrote:
Hi,
Please review the following patch to reinstate pack200 tests for the
fastest
systems.
In my testing I also found that launcher's I18NJarTest was failing
with a known
issue on Macs, so I have taken the opportunity to add this as well.
The change looks okay to me, although for the pack200 tests then I
assume the issue is really just old sparc machines that refuse to die
and so continue to be used for testing. In that case, then maybe the
exclude should be just for solaris-sparc and solaris-sparcv9. I guess
you've probably thought about that already and that once the tests
are running on at least one of two platforms it means you get the
test coverage that it needed here.
Thanks Alan for looking at this.
Right, for a sanity check , one platform should suffice. I went for
the bonus point and
added windows (32/64) as well, to err on the side of safety.
Kumar
-Alan.
