On 11/02/2013 03:59, Martin Buchholz wrote:


On Sat, Feb 9, 2013 at 1:50 AM, Peter Levart <[email protected] <mailto:[email protected]>> wrote:


    Also, this does not disable ZIP64 - it only disables it when it is not
    needed (most other zip implementations can still read the output) "inhibit"
    seems better than "disable".

    disfavor ?

I went for "inhibit".

There's now a shiny new test case .
Same Bat Place: http://cr.openjdk.java.net/~martin/webrevs/openjdk8/useZip64For64kEntries/ <http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk8/useZip64For64kEntries/>
I am now happy with this change and would like to submit.
As always, I need a bug id.
The test looks fine, looks like it won't be too slow. One improvement would be to use try-with-resources.

-Alan.

Reply via email to