Looks Ok Dmeetry. Best Lance On Feb 11, 2013, at 3:58 PM, Dmeetry Degrave wrote:
> Hi, > > Resending a code review request for a corba fix for 7 and 8, which is > identical to fix went to earlier releases. > > A wrong unexpectedUnionDefault exception is thrown in TypeCode handling code > when an OptUnion value with false discriminator is inserted into any of NV > struct on server side for the following idl: > > union OptUnion switch (boolean) { > case TRUE: > unsigned short opt; > }; > > struct NV { > string name; > any value; > }; > > typedef sequence<NV> NVSeq; > > interface OptUnionInterface > { > OptUnion retrieve (); > NVSeq retrieveNVSeq(); > }; > > The fix is elimination of the exception, as it's wrong. There is a test case > attached to the bug, though it requires a CORBA env setup. > > webrev : http://cr.openjdk.java.net/~dmeetry/7199858/webrev.0/ > jdk7 bug w/ desc: http://bugs.sun.com/view_bug.do?bug_id=7199858 > jdk8 bug w/ comm: http://bugs.sun.com/view_bug.do?bug_id=8005310 > > Fix was reviewed by Mark Sheppard and verified in the field. > > thanks, > dmeetry
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com