On 21/02/2013 19:45, Mandy Chung wrote:
Alan,
This fix looks good and the "## fast path ..." comment can be taken
out as Chris pointed out.
Yes, I put that comment in there as a reminder and should have removed
it - thanks (and Chris).
A minor note - the list of known jar files seems to be incomplete
(e.g. tzdb.jar and some windows-specific ones). I think it may be
better to file a bug to follow up this and maybe even better to
replace the hardcoded list with other mechanism (if appropriate).
The list doesn't have to be complete, this is just the JAR files that
will be skipped. I completed list that hardcoded list needs clean-up
(even the construction of) and that's the clean-up I hinted at in the
first mail. I decided not to change in this round as I just wanted to
restore the startup. Also it takes time to verify startup across a
number of platforms so changing code in this area takes a bit longer to
verify.
-Alan
