----- Original Message ----- > On 14/03/2013 14:03, A. Sundararajan wrote: > > Please review http://cr.openjdk.java.net/~sundar/8010083/ > > > > Thanks > > -Sundar > This looks okay to me but do we want to be changing the ASM source? > It > has a few compiler warnings too. Maybe Rémi or someone closer to ASM > could get the issues fixed upstream (if they aren't already) so that > we > are not out of sync. >
I'd concur with that statement. Making local changes to upstream code can become a headache in the long run. So speaks the maintainer of a project that does just that with OpenJDK... ;) > -Alan > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
