On 24/04/2013 00:09, Henry Jen wrote:
Hi,
Please review static Stream factory methods and methods for Arrays.
Webrev is at
http://cr.openjdk.java.net/~henryjen/tl/8012650-8011918.0
Stream methods are covered in a test suite which will be put back soon
once all depends part is in place.
Arrays setAll and parallelSetAll methods has test included.
Cheers,
Henry
I went over the webrev and don't see anything obviously wrong.
Will you add the @since 1.8 to the Arrays methods before pushing this?
The stream methods have it, just not the setAll/parallelSetAll.
Another minor comment is that the stream methods specify NPE but that
isn't strictly requires as the Arrays class has a statement in the class
description to say that all methods throw NPE if the array reference is
null.
-Alan.
