The restyling changes obfustucated things a bit but I didn't see anything of concern in casual review.
I had hoped to see the updated SmallSet that didn't try to implement Iterator directly. Looks OK. The testing, which you have done, is the important qualifier for this change. Mike On Apr 25 2013, at 13:24 , Kumar Srinivasan wrote: > Here is the webrev: > http://cr.openjdk.java.net/~ksrini/8013225/webrev.0/ > > Thanks > Kumar > >> Hello, >> >> Please review changes which essentially contains asm5_future in asm's >> mainline >> repository, I have tested this patch with Nashorn (so has Sundar), as well >> as Lambda's >> usage. >> >> Fixes that I know of: >> 1. supports v52.0 class files and JSR 308/Type Annotations changes >> >> Thanks to Remi >> 2. elimination of "_" usages in variable names >> 3. several javadoc changes and one reported by Sundar >> http://jbs.oracle.com/bugs/browse/JDK-8010083 >> >> >> Thanks >> Kumar >> >
