On May 2, 2013, at 8:22 AM, Alan Bateman <[email protected]> wrote:
> On 02/05/2013 07:52, Henry Jen wrote: >> Hi, >> >> Please review a couple stream access API proposed for >> java.nio.file.Files and java.nio.file.DirectoryStream, >> >> http://cr.openjdk.java.net/~henryjen/ccc/8006884.0/webrev/ >> http://cr.openjdk.java.net/~henryjen/ccc/8006884.0/specdiff/ >> >> Cheers, >> Henry > One corner case that I meant to ask about is the expected behavior when > someone attempts to do something on a CloseableStream after it is closed? > It's not specified so it's not testable but I'm just wondering if the > Iterator throwing ISE is right or whether this should be an > UncheckedIOException. As I understand it, an ISE will be thrown if someone > attempts to use a stream that already been operated on, so this really just > leaves the uninteresting case where the stream is closed before using it. I think UncheckedIOException is expected as read on a closed InputStream should throw IOException. A related question, what do we expect when iterate a DirectoryStream which is closed after we obtain the iterator? Cheers, Henry
