On 14/05/2013 20:51, Xueming Shen wrote:
Thanks Mandy!
Webrev has been updated to put the "final" back as suggested.
http://cr.openjdk.java.net/~sherman/8012326/webrev/
https://jbs.oracle.com/bugs/browse/JDK-8014565 has been filed for future
enhancement of ExtededCharsets class.
-Sherman
The updated webrev looks fine to me, the holder idiom in Charset makes
me much better.
(For ISO2022_JP_2/MSISO2022JP then I thought the previous approach was
fine as I don't think the encoders/decoders needs to be singletons. What
you have is okay though, just adds a bit of class footprint).
-Alan.
