On 24/05/2013 23:53, Martin Buchholz wrote:
Thanks very much for adding this support. Users will be happy.
You could make it clearer in the javadoc that you are storing and returning
times in seconds since the epoch, and that the epoch is Jan 1, 1980.
Note that we now have both kinds of epochs: 1970 and 1980, for extra
confusion.
Also, I guess the zip world doesn't have any kind of year 2038 strategy?
Probably roll over as we get close to 2038 and pray?
Probably include links to both appnotes, the pkware one and info-zip's
modified version.
I agree, it's good to add this.
The package-info already has a link to APPNOTE.TXT and also the Info-ZIP
format. However it might be good to at least have ZipEntry.getTime's
javadoc mention that the time may be coming from extra block. This would
provide coverage for cases where they don't match.
-Alan.
